itzg / itzg/docker-minecraft-server

modrinth: support projects that declare "unknown" as server-type

Open
#2,929 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Shell
Stars
14.3k
Forks
1.9k
Avg merge
2d 10h
Merged PRs (30d)
31

Description

Until https://github.com/modrinth/code/issues/2590 is resolved, there are projects like https://api.modrinth.com/v2/project/dynmap that report a `server_side` of "unknown" even though that is not a documented enum value in the project model: https://docs.modrinth.com/#tag/misc/operation/statistics

[Reported in Discord](https://discord.com/channels/660567679458869252/660569755320844308/1255637027228090398)

```
[mc-image-helper] 21:31:57.397 ERROR : 'modrinth' command failed. Version is 1.37.3
me.itzg.helpers.errors.GenericException: Failed to parse response body into list of class me.itzg.helpers.modrinth.model.Project: Cannot deserialize value of type `me.itzg.helpers.modrinth.model.ServerSide` from String "unknown": not one of the values accepted for Enum class: [optional, unsupported, required]
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the Modrinth command's Project response parsing and the ServerSide model named in the error. Reproduce the failure using the dynmap project response, then verify that a server_side value of "unknown" no longer prevents the project list from being parsed successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.