itzg / itzg/docker-minecraft-server

GENERIC_PACK_STRIP_DIRS is not working

Open
#1,236 0 comments 0 reactions 0 assignees View on GitHub
bug status/needs triage
Dominant language
Shell
Stars
14.3k
Forks
1.9k
Avg merge
2d 10h
Merged PRs (30d)
31

Description

### Describe the problem

I got a .zip modpack where the folder structure is _/modpack folder name/mods folder_ but when I load the zip with

```
- GENERIC_PACK=/modpacks/modpack.zip
- GENERIC_PACK_STRIP_DIRS=1
```
the server starts creating the game data but the mods folder is empty. If I repeat the process manually editing out the modpack folder name from the zip leaving the mods folder and the other files directly in to the zip root it works

### Container definition

```
Paste run command or compose file here
```
minecraft:
[...]
environment:
- MAX_MEMORY=8G
- EULA=TRUE
- ENABLE_RCON=false
- MAX_PLAYERS=8
- OPS=_redacted_
- VIEW_DISTANCE=15
- ALLOW_FLIGHT=true
- MAX_TICK_TIME=-1
- TYPE=FABRIC
- VERSION=1.18.1
- GENERIC_PACK=modpack.zip
- GENERIC_PACK_STRIP_DIRS=1
volumes:
- ./containers/games/minecraft/data:/data
- ./containers/games/minecraft/modpacks:/modpacks:ro
[...]

### Container logs

```
Paste logs here
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the startup handling for GENERIC_PACK and GENERIC_PACK_STRIP_DIRS in the container. Reproduce the reported archive layout with a Fabric 1.18.1 server, compare it with an archive whose contents are at the root, and verify that the mods directory is populated in both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, shell
Domain
devops
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.