itzg / itzg/docker-mc-backup

The "sync" command in backup-loop.sh

Open
#189 9 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
538
Forks
69
Avg merge
3h 28m
Merged PRs (30d)
2

Description

The following line in backup-loop.sh is missing the "rcon-cli" portion of the command:
`retry ${RCON_RETRIES} ${RCON_RETRY_INTERVAL} sync`

This results in the command being executed in the mc-backup container instead, calling the Linux "sync" command. There is no need for this command to run inside the mc-backup container and it appears to have been intended to be the `sync` command in Minecraft server, which should follow the save-all command.

Suggested fix is to simply add the "rcon-cli" command to this line. Will submit a PR; opening this issue for tracking purposes.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading backup-loop.sh and tracing the retry invocation following save-all. Verify the command target inside the mc-backup container and compare it with the surrounding rcon-cli calls. Done means Minecraft receives the sync command rather than the container's Linux sync command.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, shell
Domain
devops, infrastructure
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.