itsleeds / itsleeds/OSMtools

hardcoded path_osmfilter to windows version

Open
#5 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
3
Forks
1
PR merge metrics
No merged PRs in 30d

Description

https://github.com/ITSLeeds/OSMtools/blob/d31460c6916a421aa587297a8190a7db1e8c1dba/R/osmfilter.R#L37-L48

Suggested update:

if (checkmate::test_os("windows")) {
path_osmfilter <- file.path(path.package("OSMtools"),
"osmfilter.exe")
}
else if (checkmate::test_os("linux")) {
path_osmfilter <- file.path(path.package("OSMtools"),
"osmfilter32")
}
else if (checkmate::test_os("mac")) {
path_osmfilter <- file.path(path.package("OSMtools"),
"osmfilter.rb")
}
else {
stop("OS not supported")
}
#path_osmfilter <- file.path(path.package("OSMtools"), "osmfilter.exe")
path_osmfilter <- normalizePath(path_osmfilter)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.