itsgoingd / itsgoingd/clockwork
Potential sensitive data exposure in PhpDataSource::getRequestHeaders()
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 6k
- Forks
- 333
- Avg merge
- 5m
- Merged PRs (30d)
- 1
Description
Probably not a big deal because why would we be putting passwords in cookies...
In PhpDataSource you are running $_COOKIE through DataSource::removePasswords(). But in PhpDataSource::getRequestHeaders() nothing is done about the cookie header which contains the same data.
Maybe the cookie header could just be dropped? Data is already collected elsewhere.
Alternatively parse the header into an array, remove passwords and put it back together as a string.
Or maybe just forget about it because why would we store our password in a cookie?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read PhpDataSource::getRequestHeaders() alongside DataSource::removePasswords(), then trace how $_COOKIE and the cookie header are collected. Decide on a consistent treatment for sensitive cookie values and verify that request headers no longer expose password data.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100