itinance / itinance/react-native-fs

The latest tag 2.14.1 has incorrect format

Open
#740 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
5k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

Not sure if intentional but it seems the latest tag has incorrect format. This seems to cause problems if one wants to add the RNFS pod manually instead of using use_native_modules in a pod target.

As an example, using the following in package.json:
`"react-native-fs": "2.14.1"`

and adding the following to Podfile
`pod 'RNFS', :podspec => '../node_modules/react-native-fs'`

Will result in:

```
[!] Error installing RNFS
[!] /usr/bin/git clone https://github.com/itinance/react-native-fs /var/folders/nk/13j2yn9d2t55hf4d77wc8txw0000gp/T/d20190822-65224-sh2r5q --template= --single-branch --depth 1 --branch v2.14.1

Cloning into '/var/folders/nk/13j2yn9d2t55hf4d77wc8txw0000gp/T/d20190822-65224-sh2r5q'...
warning: Could not find remote branch v2.14.1 to clone.
fatal: Remote branch v2.14.1 not found in upstream origin
```

If anyone has the same issue I solved it by forking, updating the podspec to point to the forked repo and then added a tag with the format "v2.14.1". Would love this repo having a correct tag so I can switch back and delete my fork.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.