itinance / itinance/react-native-fs

Merge TypeScript declaration with DefinitelyTyped

Open
#636 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
5k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

The current [TypeScript declaration file](https://github.com/itinance/react-native-fs/blob/master/index.d.ts) is missing a few functions (e.g. `appendFile`) that are covered by the [one in DefinitelyTyped's repo](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native-fs/index.d.ts) (@pocesar and @josephroquedev are listed as the maintainers there). The one on DefinitelyTyped is also more complete, avoiding the `any` type for some options (e.g. encodings).

Would there be any objections to merging the two declaration files here?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.