itinance / itinance/react-native-fs

Incorrect Project Reference in Windows Project

Open
#626 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
5k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

The project reference to `react-native` in the windows project seems to have the incorrect relative path with an initial link.
https://github.com/itinance/react-native-fs/blob/d7f13fabef208f77fedf6eefb71612a6545cafc9/windows/RNFS/RNFS.csproj#L134

Assuming that the `RNFS.csproj` is held in `node_modules/react-native-fs/windows/RNFS` the above path would not exist.

This is resolved when the parent solution is opened as the reference is resolved and the project file is updated to `..\..\..\react-native-windows\ReactWindows\ReactNative\ReactNative.csproj`.

I propose that this relative path should be used by default.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.