itinance / itinance/react-native-fs

`UploadFileItem.filetype` should be defined as optional

Open
#1,161 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
5k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

When using the `RNFS.uploadFiles` method, there is a type definition named [`UploadFileItem` with field `filetype` where the docs say...](https://github.com/itinance/react-native-fs#uploadfilesoptions-uploadfileoptions--jobid-number-promise-promiseuploadresult-)
> if not defined it will get mimetype from filepath extension

However, the type defines that field as required so it must be defined. Can we please switch it to be optional? Otherwise, we have to explicitly specify the filetype.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.