itinance / itinance/react-native-fs

Package entry point is not ECMAScript

Open
#1,023 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
5k
Forks
1k
PR merge metrics
No merged PRs in 30d

Description

`FS.common.js` is not valid ES, and Node throws:

```none
/.../node_modules/react-native-fs/FS.common.js:30
var normalizeFilePath = (path: string) => (path.startsWith('file://') ? path.slice(7) : path);
^

SyntaxError: Unexpected token ':'
```

Of all the liberties package maintainers take, serving a straight-up different language at the entry point is one of the bigger head-scratchers I've seen.

Also, Flow sucks, and you should just use TS.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.