iterative / iterative/gatsby-theme-iterative

Heroku infinite deployment attempt even on failure

Open
#203 2 comments 0 reactions 0 assignees View on GitHub
🐛 type: bug p0-critical
Dominant language
JavaScript
Stars
6
Forks
2
PR merge metrics
No merged PRs in 30d

Description

We have been getting infinite deployment issue with heroku on all of our websites
- https://github.com/iterative/dvc.org/pull/4485
- https://github.com/iterative/dvc.org/pull/4487
- https://github.com/iterative/iterative.ai/pull/839

I opened a ticket on Heroku Support in addition to this to research more and the Heroku team replied it could be because we have `Wait for CI to pass`. So upon digging further, it turns out we have a loop because of `Wait for CI to pass` in Heroku and link check GHA workflow which gets triggered on `deployment status`. Since it's getting triggered even on failure causing the change in CI which in turn triggers the `Heroku`.

There is a few more test I am doing
- https://github.com/iterative/dvc.org/pull/4525
- https://github.com/iterative/dvc.org/pull/4526
- Will also try to address https://github.com/iterative/iterative.ai/issues/810

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reviewing the Heroku “Wait for CI to pass” setting and the link check GitHub Actions workflow described in the issue, along with the referenced deployment pull requests. Confirm how deployment status events trigger the workflow and define done as failed deployments no longer causing a repeated Heroku deployment loop.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, devops
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.