iterative / iterative/cml

fix/upgrade integration tests

Open
#538 6 comments 2 reactions 2 assignees Claimed by @0x2b3bfa0 View on GitHub
blocked p1-important technical-debt testing
Dominant language
JavaScript
Stars
4.2k
Forks
345
PR merge metrics
No merged PRs in 30d

Description

- tests sometimes pass despite introducing breaking changes
+ The main reason was having introduced a gyp lib that needed sudo permissions breaking the cml service inside the CML aws image managed by our terraform provider
- should use external repo & `send-check` to
+ avoid spamming CML with comments
+ avoid too many token permissions

We need:
- Integration tests that take the whole picture
- testbot should do the trick however the CML image is picking from master

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.