iterative / iterative/cml

Self-hosted runner failing when trying to use new Gitlab runner authentication flow

Open
#1,491 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
4.2k
Forks
345
PR merge metrics
No merged PRs in 30d

Description

The current code for acquiring a runnerToken attempts to fetch a token in the following order:

1. Use the legacy endpoint (`/projects/`
2. Use the new runner authentication endpoint (`/user/runners`)

However, in the legacy path, the legacy endpoint can return `undefined` for the token when legacy runner tokens are not enabled. This leads to [the null check](https://github.com/iterative/cml/blob/a3a66c74b218b08710f42bf599b066e37cb4cba7/src/drivers/gitlab.js#L154) entry to the new endpoint code path failing.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.