iterative / iterative/cml

fix GHA workflow timeout-minutes 4320

Open
#1,097 1 comment 0 reactions 1 assignee Claimed by @dacbd View on GitHub
bug ci-github cml-runner
Dominant language
JavaScript
Stars
4.2k
Forks
345
PR merge metrics
No merged PRs in 30d

Description

there are quite a few [workflows with hardcoded `timeout-minutes: 4320`](https://github.com/search?q=cml+timeout-minutes%3A+4320&type=code). Said workflows are broken due to #1067.

Also users who notice the warning and upgrade to `timeout-minutes: 50400` will still see an annoyingly persistent warning.

As per https://github.com/iterative/cml/pull/1067#discussion_r923619072 we should:

- [ ] increase visibility or automate a fix
+ minimum (easy): throw an error instead of logging a warning
+ ideally (more involved): parse the workflow file and set `GH_5_MIN_TIMEOUT` accordingly
- [ ] better logging
+ https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-error-message and/or https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#adding-a-job-summary, etc.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.