iterative / iterative/cml.dev

Update `Video` `play()`/`pause()` code, possibly clearing some Sentry errors

Open
#52 0 comments 0 reactions 0 assignees View on GitHub
p2-nice-to-have
Dominant language
TypeScript
Stars
13
Forks
22
PR merge metrics
No merged PRs in 30d

Description

* `video.play()` and `video.pause()` return a promise and we should place our code in something like a `try` and `catch` block. Not doing so may be causing some errors that were caught by Sentry
* We could also use a `catch` block to take care of other Sentry `video` errors that we don't need to worry about

## Links about issue
* [Info about `video.play() `](https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/play)
* [Google Developers article about errors](https://developers.google.com/web/updates/2017/06/play-request-was-interrupted)

## Sentry errors that could be resolved
* [CML-DEV-5](https://sentry.io/organizations/iterative/issues/2380260528/merged/?project=5747165&query=is%3Aunresolved)
* [CML-DEV-C](https://sentry.io/organizations/iterative/issues/2393142694/?project=5747165&query=is%3Aunresolved)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.