istio / istio/api

Add lint to the API repo

Open
#3,450 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
519
Forks
612
Avg merge
18h 35m
Merged PRs (30d)
23

Description

If you introduce curly unicode quotes (““ instead of ""), you will eventually break the linter on istio.io.

For example https://github.com/istio/api/pull/3426

> // For text format, the output of the empty operator is changed from “-“ to an empty string.

leads to https://github.com/istio/istio.io/pull/16281 ([prow](https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio.io/16281/lint_istio.io/1896743955798691840))

>./content/en/docs/reference/config/istio.mesh.v1alpha1/index.html:1707:For text format, the output of the empty operator is changed from “-“ to an empty string.
> Ensure content only uses standard quotation marks and not “

Could we please introduce some light linting to PRs here for this use case, which has now happened at least enough times that i remember it?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.