istanbuljs / istanbuljs/test-exclude

The filename field should be compatible?

Open
#52 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
10
Forks
18
PR merge metrics
No merged PRs in 30d

Description

in the 'index.js' file
in the function shouldInstrument
```
if (
this.extension &&
!this.extension.some(ext => filename.endsWith(ext))
) {
return false;
}
```
sometimes filename is undefined then report error

![image](https://user-images.githubusercontent.com/24777461/225569713-fe4729cc-b0a2-42e9-a2e8-5785578393ff.png)

Can it be changed to `!this.extension.some(ext => filename && filename.endsWith(ext))`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.