istanbuljs / istanbuljs/spawn-wrap

`process.binding` deprecation

Open
#89 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
41
Forks
18
PR merge metrics
No merged PRs in 30d

Description

Node started to deprecate `process.binding`: https://nodejs.org/dist/latest-v11.x/docs/api/deprecations.html#deprecations_dep0111_process_binding

This function is used by spawn-wrap to patch `spawnSync`.

It is possible to avoid patching the internals at the top level by creating a wrapped `spawn` function. The main issue is caused by processes deep in the process tree: spawn-wrap tries to hook into user-code spawning processes and we cannot change it so we still have to patch the internals.

There is an open Node issue discussing the issue:

/cc @isaacs @bcoe @coreyfarrell

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.