isomorphic-git / isomorphic-git/lightning-fs

Incorrect `IDB` interface

Open
#126 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
610
Forks
62
Avg merge
14h 47m
Merged PRs (30d)
1

Description

I noticed that current `IDB` interface had two errors:
1. The constructor type was typed as a regular function
2. The `readFile` was mis-typed as `loadFile`

`/lightning-fs/index.d.ts`
```diff
export interface IDB {
- constructor(dbname: string, storename: string): IDB
+ new (dbname: string, storename: string): IDB
saveSuperblock(sb: Uint8Array): TypeOrPromise
loadSuperblock(): TypeOrPromise
- loadFile(inode: number): TypeOrPromise
+ readFile(inode: number): TypeOrPromise
writeFile(inode: number, data: Uint8Array): TypeOrPromise
wipe(): TypeOrPromise
close(): TypeOrPromise
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.