isocpp / isocpp/CppCoreGuidelines

not_null cannot (and should not) be used with span

Open
#399 5 comments 0 reactions 1 assignee View on GitHub

@hsutter is already working on this.

Since Oct 17, 2016.

open
Dominant language
CSS
Stars
45.3k
Forks
5.6k
No merged PRs in 30d

Description

F.18 suggests that not_null can be used with span and string_span, but my tests would suggest otherwise. This behaviour seems correct, as arrays and strings cannot be null (null std::array or std::string anyone?) Indeed, span's operator bool() tests for "empty" status, and trying to compare a span with nullptr results in a compiler error.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.