isocpp / isocpp/CppCoreGuidelines

F.16 Is there any reason for cheap-to-copy types (e.g. int, bool, etc.) not be passed as const value?

Open
#2,056 1 comment 0 reactions 1 assignee View on GitHub

@hsutter is already working on this.

Since Apr 13, 2023.

Dominant language
CSS
Stars
45.3k
Forks
5.6k
PR merge metrics
No merged PRs in 30d

Description

From my experience I prefer the following rule of thumb when writing functions: all input parameters are defined as const or const&.

In my opinion this makes the intent clear and easy to stick to it and also helps to avoid uncontrollable update of the parameter copy inside the function body (the worst case is legacy code with long functions).

Is there any downside to it?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.