isocpp / isocpp/CppCoreGuidelines
missing note in parameter passing rules images
@hsutter is already working on this.
Since Oct 14, 2021.
- Dominant language
- CSS
- Stars
- 45.3k
- Forks
- 5.6k
- PR merge metrics
- No merged PRs in 30d
Description
Checking the parameter passing guidelines I realized that about the note
or return unique_ptr/make_shared at the cost of a dynamic allocation
in both "normal" and "advanced" images there is the note but the * references inside the tables are missing;
Moreover, I report here for reference the frame in the video where @hsutter presented it, and from which it is possible to see the original image and where the note should be put.
reference: https://www.youtube.com/watch?v=xnqTKD8uD64&t=3507s
I didn't open a PR because I don't know if there is any layout/template to use for generating the image.
In case, I'll look forward to your indications and I'll be glad to do my small contribution.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.