isocpp / isocpp/CppCoreGuidelines

Never delete a move constructor or move assignment operator

Open
#1,670 5 comments 2 reactions 1 assignee View on GitHub

@cubbimew is already working on this.

Since Sep 3, 2020.

Dominant language
CSS
Stars
45.3k
Forks
5.6k
No merged PRs in 30d

Description

As quoted from @jwakely in https://github.com/microsoft/GSL/pull/842#issuecomment-673403244

Never delete a move constructor or move assignment operator. If you want moving to be equivalent to copying then do not write move ctor/assignment, and ensure there is a user-declared copy ctor or copy assignment operator or both (or a user-declared destructor) N.B. user-declared not user-provided, which means not_null(const not_null&) = default; is fine.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.