isocpp / isocpp/CppCoreGuidelines
Should SF.7 be less specific on how the namespace is modified, ban other mutations in .h files?
Open
@GabrielDosReis is already working on this.
Since Sep 3, 2020.
- Dominant language
- CSS
- Stars
- 45.3k
- Forks
- 5.6k
- PR merge metrics
- No merged PRs in 30d
Description
SF.7: Don't write using namespace at global scope in a header file
the global namespace can be modified as follows
// foo.h
namespace foo {
using namespace bar;
}
I've assume this rule intends to ban namespace mutations (other than straight additions), but but as written allows this. Should this be disallowed?
I suspect this was written to allow use of namespace aliases in functions scopes but missed this case.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.