isocpp / isocpp/CppCoreGuidelines

C.121: "Reason" part tries to explain why containing data in interface class is bad, but example fails to show it

Open
#1,535 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
CSS
Stars
45.3k
Forks
5.6k
PR merge metrics
No merged PRs in 30d

Description

C.121 has
A class is more stable (less brittle) if it does not contain data.
as its first sentence, but its example only shows why virtual destructor is needed

Why is it bad to have data members in interfaces?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the C.121 section in the C++ Core Guidelines and compare its opening rationale with the current example. Clarify why data members make interface classes less stable, using an example that demonstrates that reason; done means the explanation and example address the same concern.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.