isocpp / isocpp/CppCoreGuidelines
Should Expects be required to abort?
Open
@hsutter is already working on this.
Since Oct 1, 2020.
- Dominant language
- CSS
- Stars
- 45.3k
- Forks
- 5.6k
- PR merge metrics
- No merged PRs in 30d
Description
The guidelines say here that GSL Expects always aborts on failure.
http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#SS-assertions
However, Microsoft's GSL implementation has a mode that can alternatively throw on failure. see here microsoft/GSL#775 which prevents making some functions unconditionally noexcept.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.