isocpp / isocpp/CppCoreGuidelines

consider updating gsl::joining_thread to be std::jthread

Open
#1,503 5 comments 1 reaction 1 assignee View on GitHub

@GabrielDosReis is already working on this.

Since Oct 10, 2019.

Dominant language
CSS
Stars
45.3k
Forks
5.6k
No merged PRs in 30d

Description

Microsoft::GSL has yet to implement joining_thread and with std::jthread being standardized, we should consider updating the documentation in the CoreGuidelines to std::jthread.

Today the Guidelines only mention C++17 features, this would imply adding documentation concerning C++20 features.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.