isocpp / isocpp/CppCoreGuidelines

Assigning array to span in ES.42

Open
#1,306 11 comments 0 reactions 1 assignee View on GitHub

@hsutter is already working on this.

Since Jan 10, 2019.

Dominant language
CSS
Stars
45.3k
Forks
5.6k
PR merge metrics
No merged PRs in 30d

Description

In the first f2 function instead of span<int> a = {arr, pos};, we should use gsl::span<int> a(arr.data(),pos);.
Link - http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es42-keep-use-of-pointers-simple-and-straightforward

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.