isocpp / isocpp/CppCoreGuidelines

C.161 given reason and example are confusing

Open
#1,131 4 comments 3 reactions 1 assignee View on GitHub

@hsutter is already working on this.

Since Jan 22, 2018.

Dominant language
CSS
Stars
45.3k
Forks
5.6k
No merged PRs in 30d

Description

The reason says: "If you use member functions, you need two"
This is true only if the two arguments of the symmetric operator are of different type.
But the example shows the equal operator comparing two objects of the same type, which is the case when having it as a member function would work just as the same: you wouldn't need two contrary to what is stated in the reason.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.