isl-org / isl-org/Open3D

Fitness definition in Documentation is wrong

Open
#7,503 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
14k
Forks
2.6k
Avg merge
5d 18h
Merged PRs (30d)
6

Description

In https://www.open3d.org/docs/latest/tutorial/Basic/icp_registration.html
and https://www.open3d.org/docs/latest/cpp_api/classopen3d_1_1t_1_1pipelines_1_1registration_1_1_registration_result.html#a612ec06fe937ffbc94b0907365f58431

it says:
>fitness, which measures the overlapping area (# of inlier correspondences / # of points in target). The higher the better.

or

> For ICP: the overlapping area (# of inlier correspondences / # of points in target). Higher is better.

But that is not true. In the source code it is written as:
https://github.com/isl-org/Open3D/blob/0333798fcff5a2fe95470e69291eca6a9efbae6c/cpp/open3d/pipelines/registration/Registration.cpp#L65

The Documentation should be updated that the `source` is used and not the `target`, because it can lead to confusion in the interpretation of the fitness value as in our case.

Edit:
Just to mention it, here it is correct: https://www.open3d.org/docs/latest/tutorial/pipelines/icp_registration.html

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.