isl-org / isl-org/Open3D

Potential wrong parameter (LAMBDA_HYBRID_DEPTH) for RGBDOdometry

Open
#7,200 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
14k
Forks
2.6k
Avg merge
5d 18h
Merged PRs (30d)
6

Description

### Checklist

- [x] I have searched for [similar issues](https://github.com/isl-org/Open3D/issues).
- [x] For Python issues, I have tested with the [latest development wheel](https://www.open3d.org/docs/latest/getting_started.html#development-version-pip).
- [x] I have checked the [release documentation](https://www.open3d.org/docs/release/) and the [latest documentation](https://www.open3d.org/docs/latest/) (for `main` branch).

### Describe the issue

I have been reviewing the implementation details of RGBDOdometry and find it uses 0.968 by default for the weight on geometric objective (https://github.com/isl-org/Open3D/blob/main/cpp/open3d/pipelines/odometry/RGBDOdometryJacobian.cpp#L19), while the supplementary of the paper said 0.5 for RGBD image alignment (Sec Appendix. B last sentence, https://jaesik.info/publications/data/17_iccv_supp.pdf). I'm raising this issue to confirm if this is set by intention or a bug. I can help send a PR if it's the latter.

### Steps to reproduce the bug

```python
N/A
```

### Error message

N/A

### Expected behavior

N/A

### Open3D, Python and System information

```markdown
N/A
```

### Additional information

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.