isl-org / isl-org/Open3D

Support `int32` advanced indexing. Default TriangleMesh index use `uint32`?

Open
#4,927 0 comments 0 reactions 0 assignees View on GitHub
feature request
Dominant language
C++
Stars
14k
Forks
2.6k
Avg merge
5d 18h
Merged PRs (30d)
6

Description

### Checklist

- [X] I have searched for [similar issues](https://github.com/isl-org/Open3D/issues).
- [X] For Python issues, I have tested with the [latest development wheel](http://www.open3d.org/docs/latest/getting_started.html#development-version-pip).
- [X] I have checked the [release documentation](http://www.open3d.org/docs/release/) and the [latest documentation](http://www.open3d.org/docs/latest/) (for `master` branch).

### Proposed new feature or change

- Numpy
- Default int: int64
- Default float: float64
- Advanced indexing with int32: Yes
- Advanced indexing with int64: Yes
- PyTorch
- Default int: int32
- Default float: float64
- Advanced indexing with int32: No
- Advanced indexing with int64: Yes
- Open3D current
- Default int in TriangleMesh index: int64
- Default float in TriangleMesh vertex: float32
- Advanced indexing with int32: No
- Advanced indexing with int64: Yes
- Open3D proposed
- Default int in TriangleMesh index: uint32 <--------
- Default float in TriangleMesh vertex: float32
- Advanced indexing with int32: Yes <-------
- Advanced indexing with int64: Yes

- If # vertices is larger than the range of int32, there should be some intelligent way to warn the user about the index type.
- Decide between int32 and uint32.

### References

_No response_

### Additional information

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.