isl-org / isl-org/Open3D

linear depth for orthographic projection with CaptureDepthFloatBuffer

Open
#2,315 0 comments 0 reactions 2 assignees Claimed by @errissa View on GitHub
feature request legacy (Open3D 0.x API) visualization
Dominant language
C++
Stars
14k
Forks
2.6k
Avg merge
5d 18h
Merged PRs (30d)
6

Description

For orthograph projection, when we get depth float buffer with `CaptureDepthFloatBuffer`, I was expecting depth to be linearly converted from normalized device coordinate system to eye coordinate system. However, it converts them non-linearly (as needed for perspective projection) https://github.com/intel-isl/Open3D/blob/master/cpp/open3d/visualization/visualizer/VisualizerRender.cpp#L321. I think it should be handled in different manner for orthographic projection.

z_depth = (double)p_depth[j] * (z_far - z_near) + z_near;

Please correct me if wrong and if the difference between orthographic and perspective projection for converting p_depth to z_depth is handled else where.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.