ish-app / ish-app/ish

Terminal gains an extra row when the output scrolls off-screen

Open
#2,110 0 comments 0 reactions 0 assignees View on GitHub
unconfirmed
Dominant language
C
Stars
20.5k
Forks
1.5k
PR merge metrics
No merged PRs in 30d

Description

On iSH 1.3.1 (build 489):

It appears that the terminal gains an extra row if the scrollback buffer is not empty. This only happens when using an external keyboard with "Hide with external keyboard" enabled.

The issue doesn't seem to be related to the window configuration, as I can reproduce it consistently in Fullscreen, Split View and Slide Over windows.

It's one of those issues where a screenshot might be a lot more useful then a description:

![image](https://user-images.githubusercontent.com/2833247/236638050-0797c612-dede-4b07-b4bd-1a2b29bb7007.jpeg)
![image](https://user-images.githubusercontent.com/2833247/236638079-6378d80c-f676-47a2-ac35-415b63a8a116.jpeg)

PS: A big heartfelt *thank you* for creating and maintaining iSH, guys. This is, hands down, the most used app on my iPad!

Contributor guide

No contributing guide indexed for this repository

Research direction

Reproduce the issue on iSH 1.3.1 with an external keyboard, “Hide with external keyboard” enabled, and a non-empty scrollback buffer across the listed window configurations. Trace the terminal layout or scrolling path responsible for the extra row; done means the terminal keeps the correct row count after output scrolls off-screen.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.