isce-framework / isce-framework/s1-reader
[Bug]: as_dict method cuts off border polygons on antimeridian
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 34
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
Checked for duplicates
Yes - I've already checked
Describe the bug
The as_dict code will cut off half the polygon for bursts on the antimeridian (-180 longitude)
https://github.com/opera-adt/s1-reader/blob/main/src/s1reader/s1_burst_slc.py#L367
See https://github.com/opera-adt/burst_db/issues/1
The anti-meridian crossing bursts (international date line) have two polygons, since it's conventional to split the latlon that way.
What did you expect?
The likely fix will be converting to a MultiPolygon which can still be represented as WKT.
Reproducible steps
No response
Environment
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/s1reader/s1_burst_slc.py line 367 and review how as_dict represents burst polygons, then compare the antimeridian case described in burst_db issue #1. Done means border polygons crossing -180 longitude are preserved as both parts, likely through a MultiPolygon representation that remains representable as WKT.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100