isce-framework / isce-framework/s1-reader
Improve annotation loading procedure in `s1_reader.burst_from_xml`
Open
@seongsujeong is already working on this.
Since Aug 28, 2022.
enhancement
needs triage
- Dominant language
- Python
- Stars
- 34
- Forks
- 16
- PR merge metrics
- No merged PRs in 30d
Description
Checked for duplicates
Yes - I've already checked
Alternatives considered
Yes - and alternatives don't suffice
Related problems
s1_reader.burst_from_xml() includes annotation reader. The logic can be improved by applying the comment below:
(https://github.com/opera-adt/s1-reader/pull/62#discussion_r953168729)
Describe the feature request
I need the logic for annotation reader to take in zipfile object, rather than xml tree, so that the s1_reader.burst_from_xml() can be less populated.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.