isce-framework / isce-framework/s1-reader

Orbit from header

Open
#40 0 comments 0 reactions 1 assignee View on GitHub

@LiangJYu is already working on this.

Since May 18, 2022.

  • #41 by @LiangJYu — open
enhancement needs triage
Dominant language
Python
Stars
34
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Checked for duplicates

Yes - I've already checked

Alternatives considered

Yes - and alternatives don't suffice

Related problems

Currently the reader only works if the external orbit file is provided.

Describe the feature request

Since the annotation file already contains the less precise orbit, I think the default behavior should be to extract the orbit from external orbit if the orbit file is provided. If the orbit file is not provided let's just extract the orbit from the header (annotation).

In the annotation file, the orbits are in <generalAnnotation/orbitList> . isce2 implementation can be reused.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.