isce-framework / isce-framework/s1-reader

Unexpected behavior when az FM rate correction can not be computed:

Open
#136 0 comments 0 reactions 1 assignee View on GitHub

@seongsujeong is already working on this.

Since Oct 11, 2023.

bug needs triage
Dominant language
Python
Stars
34
Forks
16
PR merge metrics
No merged PRs in 30d

Description

Checked for duplicates

Yes - I've already checked

Describe the bug

Currently if the user asks to compute Az FM rate correction, but the computation is not possible because of lack of metadata, then the function here and here silently goes on and returns a zero LUT instead of simply throwing an exception and failing the process.

What did you expect?

If the user asks for computing AZ FM rate correction and the computation not possible because of lack of metadata I expected the reader to throw an exception and exit. The reason is that if we have two SLCs and we successfully and correctly compute the Az FM rate for one and fail to compute Az FM rate for the other but rather return ZERO LUT then we will end up with one coregistered SLC which has accounted for Az FM rate mismatch and the other which has not and therefore we would end up with significant interferometric burst discontinuities in results of artificial offsets introduced by correcting az FM rate for one SLC and not correcting for the other.

Reproducible steps

No response

Environment

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.