isce-framework / isce-framework/isce3
Should `RadarGridParameters` allow negative ranges?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 239
- Forks
- 90
- Avg merge
- 13d 1h
- Merged PRs (30d)
- 5
Description
Currently, it's technically possible to create a RadarGridParameters object with negative-valued ranges. The constructor disallows this by raising an error if the startingRange or rangePixelSpacing was negative, but it's possible to construct a RadarGridParameters and then later assign it a negative-valued starting range or range pixel spacing via the startingRange() / rangePixelSpacing() member functions.
Should we disallow this by raising an error if a negative-valued starting range or range pixel spacing is assigned?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with cxx/isce3/product/RadarGridParameters.h, reading the constructor checks around lines 427-435 and the startingRange() and rangePixelSpacing() member functions around lines 102 and 108. Determine whether the existing nonnegative invariant should also apply after assignment; done means the chosen behavior is consistent for construction and later assignment.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100