isce-framework / isce-framework/isce3
isce3 minor build/ test questions - v 0.4
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 239
- Forks
- 90
- Avg merge
- 13d 1h
- Merged PRs (30d)
- 5
Description
Thanks for the new release. It pretty much built out of the box except for some minor issues.
-
There appears to be some discrepancy in the way
isce3andpyrediscover python versions to use. I eventually had to use both these settings:
-DPython_EXECUTABLE=path-to-python3 -DPython3_EXECUTABLE=path-to-python3to get everything aligned. -
Some the tests fail with
ctestpossibly because they are trying to reach out to a s3 bucket to get data. Is there a flag / option to disable these tests. -
yamaleis an undocumented dependency. Would it be useful to add this test atcmakestage or have it documented.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the build with both Python executable settings, then run ctest and check which tests access the S3 bucket. Review the CMake configuration and dependency setup around pyre and yamale. Done means the Python-version behavior, test-disabling option, and yamale dependency are resolved or documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, python
- Domain
- build-system, documentation, testing-qa
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100