isce-framework / isce-framework/isce3
(RSLC) Missing `_FillValue` attribute on swath polarization datasets
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 239
- Forks
- 90
- Avg merge
- 13d 1h
- Merged PRs (30d)
- 5
Description
Location: /science/LSAR/RSLC/swaths/frequency[A|B]/[HH|HV|VH|VV]
Description: XML schema expects the _FillValue attribute that is missing from all polarization datasets in the RSLC swaths.
From QA Log (example for one pol):
Attributes found in XML but not HDF5: {'_FillValue', 'isReceiveOnly'} - Dataset /science/LSAR/RSLC/swaths/frequencyA/HH
Impact: Schema non-compliance. Tools relying on this attribute to identify invalid/fill pixels may fail or produce incorrect results.
Notes:
- As noted in https://github.com/isce-framework/isce3/issues/297, per CF Conventions the
_FillValuedtype should match exactly the dtype of the raster dataset it is attached to. (e.g. both complex64, both complex32, etc.)
If it helps, here is existing ISCE3 code which creates complex-valued fill value:
Issue originally opened Apr 6, 2023: https://github-fn.jpl.nasa.gov/isce-3/isce/issues/1302
cc: @hfattahi @bhawkins
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the RSLC swath polarization datasets at /science/LSAR/RSLC/swaths/frequency[A|B]/[HH|HV|VH|VV], then compare their creation path with the complex-valued fill-value example in python/packages/nisar/workflows/h5_prep.py lines 74-87. Add the missing _FillValue attributes with dtypes matching their raster datasets, and verify that the XML and HDF5 attributes agree.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100