isce-framework / isce-framework/isce3
RUNW/GUNW `ionospherePhaseScreen` raster values if ionosphere is turned off?
@xhuang-jpl is already working on this.
Since Sep 15, 2025.
- Dominant language
- Python
- Stars
- 239
- Forks
- 90
- Avg merge
- 13d 1h
- Merged PRs (30d)
- 5
Description
This Issue is re: RUNW/GUNW ionospherePhaseScreen.
Three cases:
- There is high coherence, etc. and the ionosphere is ok
- Great! The InSAR workflow generates the
ionospherePhaseScreenraster normally.
- Great! The InSAR workflow generates the
- The coherence is very low and the interferogram is bad.
- Science team requested that the
ionospherePhaseScreenraster be set to all NaN values. They did not want these set to all zeros (0s), because0has a meaning. - This change was introduced into the InSAR workflow in PR ???. (@vbrancat ? @oberonia78 ?)
- QA was updated to not fail if
ionospherePhaseScreenis all-NaN in: https://github.com/isce-framework/nisarqa/pull/74
- Science team requested that the
- The ionosphere is turned off in the InSAR runconfig
- In this case, the InSAR workflow initialized the
ionospherePhaseScreenraster to all-zeros, and then those values are never updated later in the workflow.
- In this case, the InSAR workflow initialized the
Question: For Case 3 when the ionosphere is turned off, should the raster be updated to be all-NaN values (same as in Case 2)?
If the value 0 has actual meaning, then I think it would be misleading to set the raster to all-zeros in Case 3?
Note: If it is decided to update Case 3 so that the raster is all-NaN when the ionosphere is turned off, then QA should consider updates to no longer allow an all-Zero ionospherePhaseScreen to be ok. Please keep QA informed of any updates, thank you!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.