isar / isar/hive

HiveInterface missing 'path' parameter for boxExists & deleteBoxFromDisk

Open
#742 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
Dart
Stars
4.4k
Forks
449
PR merge metrics
No merged PRs in 30d

Description

Both `boxExists` and `deleteBoxFromDisk` have an optional named `path` parameter in `HiveImpl`:

```
Future deleteBoxFromDisk(String name, {String? path}) async {
//...
}
Future boxExists(String name, {String? path}) async {
//..
}
```

However, `HiveInterface` does not contain these parameter and as such they cannot be used:
```
Future deleteBoxFromDisk(String name);
Future boxExists(String name);
```
https://github.com/hivedb/hive/blob/413ae3594f7142eb8b4b428f60c5c090d12d0799/hive/lib/src/hive.dart#L54

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with the HiveInterface declarations in hive/lib/src/hive.dart and compare them with the boxExists and deleteBoxFromDisk signatures in HiveImpl. Expose the optional named path parameter through the interface, then verify both methods can be called with path when referenced through HiveInterface.

Written by the indexing model from the issue text.

Assessment

Tech stack
dart
Domain
database
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.