isXander / isXander/YetAnotherConfigLib

Minor Issues in 3.8.0 for 1.21.8

Open
#290 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
155
Forks
68
PR merge metrics
No merged PRs in 30d

Description

Sorry I'm to lazy to make separate issues. I only tested them on 1.21.8, might affect other version too.

  • "Legacy list scrolled" is printed via stdout when scrolling an option list.
  • The tab area y position is wrong (see first screenshot). Notice the overlap of the tab navigation bar and tab area.
    In code this.tabArea = new ScreenRect(0, 23, this.width, this.height - 24 + 1); should be this.tabArea = new ScreenRect(0, 24, this.width, this.height - 24);
  • The separator line is drawn twice (see second screenshot). For demonstration purposes I've increased the y position of the tab area. It appears that the options list draws its own separator line, which is shouldn't. I haven't looked into it. Edit: I noticed it also draws the separator line at the bottom of the list. You can't see tho it because it is off screen. (Note: It shouldn't draw a bottom separator at all)
  • The bottom option list is cut off (see third screenshot). When scrolled all the way down, the last option is slightly cut off, and there is no padding to the edge of the window.
Image Image Image

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the ScreenRect assignment for tabArea and inspect the option-list rendering and scrolling behavior described in the issue. Verify the tab area no longer overlaps navigation, stdout is quiet, separators are drawn only where intended, and the final option has padding when scrolled to the bottom.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.