isXander / isXander/YetAnotherConfigLib

`renderBackgroundTexture` called incorrectly in YACLScreen#render

Open
#135 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
155
Forks
68
PR merge metrics
No merged PRs in 30d

Description

renderBackgroundTexture is called twice during screen rendering. Once directly by YACL:
https://github.com/isXander/YetAnotherConfigLib/blob/450dbad49b72b37cdeef9b1358a59da1d66076c9/common/src/main/java/dev/isxander/yacl3/gui/YACLScreen.java#L88-L91
an another time in

YACLScreen#render
  Screen#render
    Screen#renderBackground
      Screen#renderBackgroundTexture

This doesn't cause an issue within yacl itself, but when overriding the method.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in common/src/main/java/dev/isxander/yacl3/gui/YACLScreen.java at the linked lines, then trace the Screen#render and Screen#renderBackground call chain described in the issue. Confirm how renderBackgroundTexture is reached twice; done means it is invoked only once during rendering, including when the method is overridden.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.