[Patch Request] StackOverflowException when updating visibilities for extremely large advancement trees
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 215
- Forks
- 50
- Avg merge
- 9d 6h
- Merged PRs (30d)
- 1
Description
Mojang Bug Report ID
This is fix for an issue one of my friends was having on their 1.19.2 modpack and they suggested I submit it here for inclusion rather than publish it as a separate mod myself. I don't know if there is an MC number for it, though I'm sure Mojang already knows about it because from code review I could tell the problem is already fixed in 1.20+
Bug adhere to the guidelines.
- I made sure that this bug adheres to the guidelines.
Has not already been requested.
- I am certain this patch has not already been requested.
Has not already been implemented.
- I know that this patch isn't already in the latest version of the mod.
Existing implementation
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the Existing implementation at https://github.com/Sollace/IAF and comparing it with Debugify's relevant code for updating visibilities in large advancement trees. Confirm the behavior against the 1.20+ implementation referenced in the issue, then verify that extremely large trees no longer cause a StackOverflowException.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100