isXander / isXander/Debugify

[Patch Request] MC-117944

Open
#232 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

patch request
Dominant language
Java
Stars
215
Forks
50
Avg merge
9d 6h
Merged PRs (30d)
1

Description

Mojang Bug Report ID

MC-117944

Bug adhere to the guidelines.
  • I made sure that this bug adheres to the guidelines.
Has not already been requested.
  • I am certain this patch has not already been requested.
Has not already been implemented.
  • I know that this patch isn't already in the latest version of the mod.
Further information

This is actually more than this bug, but this was the closest report I could find - there have been a lot of issues caused by this same bug for a long time, such as taking fall damage in water, from slowing down to land with an Elytra when gliding near the ground, when hitting a wall near the ground with an Elytra (stacking both the collision and fall damage despite only the collision making sense in this case as the ground isn't touched before impacting the wall and losing velocity), while going down scaffolding, from lag, or any other number of situations, though it's not really a bug in some ways, moreso just bad coding.

Fall damage is calculated based on how long you've been "falling", but what Minecraft considers "falling" can sometimes be inaccurate, causing fall damage when you realistically shouldn't taken any. A way to fix all issues with this at once would be to instead have a velocity-based fall damage calculation, but it would probably need a lot of work in order to have close enough results to the current system (while fixing issues such as gliding close to the ground slowly with an Elytra causing death, etc.)

This is probably too large and deep-rooted an issue to be fixed by this mod, but figured I'd ask anyway since the only solutions I found are extremely outdated and probably not even useful as a reference in modern versions - that said, these are some I found which fix the issue (again though, outdated), and they do cause their own issues in return, particularily with modded content which assumes normal vanilla fall damage calculations:
https://www.curseforge.com/minecraft/mc-mods/fall-damage-tweak
https://www.curseforge.com/minecraft/mc-mods/speed-based-fall-damage

This mod kind of fixes it in a way, as it implements speed-based collision damage which can be swapped to being counted as fall damage, so if normal fall damage is disabled this could stand in for it instead, though that's a clunkier way of doing it:
https://modrinth.com/mod/collision-damage

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Mojang bug report MC-117944 and inspect Debugify's current handling of fall damage; the issue names no files, tests, or entry points. Reproduce the listed Elytra, water, scaffolding, collision, and lag cases, then determine whether a focused fix is possible without changing expected vanilla or modded behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.