isXander / isXander/Controlify

Minecraft Access Conflict

Open
#650 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

mod-compatibility
Dominant language
Java
Stars
341
Forks
97
Avg merge
1h
Merged PRs (30d)
1

Description

Mod Info (fill out the following information)

  • Mod name: [e.g. Create mod]: Minecraft Access
  • Mod version: [e.g. 0.5.0 for 1.19.3]: 1.10.3

Describe the problem
A clear and concise description of what the problem with the mod is.:
When both mods are loaded, the recipebookComponent accessor conflicts because of the way controlify handles multiple versions in the same mixin.
Instead of conditionally adding the conflicting method, you should instead conditionally call the method or access the shadow.

To Reproduce
Steps to reproduce the behavior:

  1. Load both mods
  2. Open a world
  3. Enter survival (or any game mode where the recipe book is present like adventure)
  4. Click E to open the inventory
  5. Observe the game crash

Expected behavior
A clear and concise description of what you expected to happen.:
The mods do not conflict and both mods are able to access the recipe book component

Screenshots
If applicable, add screenshots to help explain your problem.

Minecraft Info (please complete the following information):

  • OS: [e.g. Windows 11]: Windows 11 Pro
  • Minecraft Version: [e.g. 22w05a]: 1.21.8
  • Controlify Version: [e.g. 0.1.0+1.19.4]: 2.3.0+1.21.8

Additional context
Add any other context about the problem here.:
https://github.com/isXander/Controlify/blob/multiversion/dev/src/main/java/dev/isxander/controlify/mixins/feature/screenop/vanilla/AbstractRecipeBookScreenMixin.java
https://github.com/minecraft-access/minecraft-access/blob/dev/common/src/main/java/org/mcaccess/minecraftaccess/mixin/AbstractRecipeBookScreenAccessor.java

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with dev/src/main/java/dev/isxander/controlify/mixins/feature/screenop/vanilla/AbstractRecipeBookScreenMixin.java and compare it with common/src/main/java/org/mcaccess/minecraftaccess/mixin/AbstractRecipeBookScreenAccessor.java. Reproduce the crash by loading both mods, opening a world, entering a mode with the recipe book, and opening the inventory. Done means both mods can access the recipe book component without the game crashing.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.