ironcore-dev / ironcore-dev/metalnet
PeeredID of Network object can be negative
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 2
- Forks
- 8
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 9
Description
Describe the bug
PeeredID of Network object can be negative, which should not be allowed and causes issue during uint32 conversion.
Expected behavior
When creating Network object with negative PeeredID, error should occur.
Additional context
Other uint32 conversions were secured with kubebuilder validation, but kubebuilder validation of []int32 slice is not possible.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in controllers/network_controller.go around the uint32 conversion at line 258, then locate the Network object definition and its existing kubebuilder validations. Ensure creating a Network with a negative PeeredID is rejected before conversion, and verify the behavior with the repository's relevant tests or validation checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100