Clean up driver dynamic library logic
Open
- Dominant language
- Python
- Stars
- 59
- Forks
- 32
- PR merge metrics
- No merged PRs in 30d
Description
We have two places where we load libamdhip64.so or equivalent and throw from C++ invoked from python, aborting the entire process.
https://github.com/iree-org/wave/blob/98106525e281b780971cbc25888d5f451475830d/wave_lang/kernel/wave/execution_engine/wave_hip_runtime.cpp#L62
https://github.com/iree-org/wave/blob/98106525e281b780971cbc25888d5f451475830d/wave_lang/kernel/wave/runtime/runtime.cpp#L67
This should be cleaned up:
- let's not duplicate code, especially with platform-specific logic;
- provide a graceful mechanism to catch this error without aborting the process
Contributor guide
Assessment
This issue has not been assessed yet.